Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cycle/annotated 4.0 support #79

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Adding cycle/annotated 4.0 support #79

merged 10 commits into from
Jan 9, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Oct 27, 2023 •
edited by butschster
Loading

  • Release cycle/annotated 4.0

@msmakouz msmakouz added the enhancement New feature or request label Oct 27, 2023
@msmakouz msmakouz self-assigned this Oct 27, 2023
@msmakouz
Merge remote-tracking branch 'origin/2.x' into annotated-4-0
b43f21f 
# Conflicts:
#	src/Bootloader/PrototypeBootloader.php
@msmakouz msmakouz marked this pull request as draft October 27, 2023 14:21
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6673bae) 80.58% compared to head (436f8c3) 80.69%.

Files Patch % Lines
...rc/Annotated/Locator/ListenerEmbeddingsLocator.php 84.61% 2 Missing ⚠️
src/Annotated/Locator/ListenerEntityLocator.php 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x      #79      +/-   ##
============================================
+ Coverage     80.58%   80.69%   +0.11%     
- Complexity      413      427      +14     
============================================
  Files            47       49       +2     
  Lines          1241     1269      +28     
============================================
+ Hits           1000     1024      +24     
- Misses          241      245       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster marked this pull request as ready for review January 8, 2024 10:53
@butschster butschster self-requested a review January 8, 2024 11:19
@butschster butschster added this to the v2.x milestone Jan 8, 2024
@butschster butschster merged commit 696a920 into 2.x Jan 9, 2024
7 checks passed
@butschster butschster deleted the annotated-4-0 branch January 9, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butschster butschster butschster approved these changes

Assignees

@msmakouz msmakouz

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@msmakouz @butschster